Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ma86 #82

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Ma86 #82

wants to merge 18 commits into from

Conversation

bjack205
Copy link
Contributor

@bjack205 bjack205 commented Jan 25, 2022

Adds the ma86 algorithm.

The wrapper is slightly different than the existing ma97 one. I personally think it's cleaner, keeping the wrappers around the ccalls looking nearly identical to the C functions, and then creating a few convenience methods to call those. If you like this, I can submit another PR that updates the ma97 interface to be similar. I personally found the ma97 wrapper a bit confusing since it used different names and call signatures from the C wrapper. We can keep the existing methods to not break any existing code, or simply deprecate them.

As a quick summary, the proposed API for Ma86 looks like this (as detailed in the docstring):

ma86 = Ma86(A)  # automatically converts to lower triangular
HSL.factor!(ma86)
x = copy(b)
HSL.solve!(ma86, x)
x = HSL.solve(ma86, b)

Or

ma86 = Ma86(A)
x = copy(b)
HSL.factorsolve!(ma86, x)
x = HSL.factorsolve(ma86, b)

Or a wrapper around the LinearAlegbra methods:

ma86 = Ma86(A)
x = ma86 \ b
x = copy(b)
ldiv!(ma86,x)

@bjack205 bjack205 marked this pull request as ready for review January 25, 2022 23:12
@dpo
Copy link
Member

dpo commented Jan 26, 2022

@bjack205 Many thanks. Could you please remove the commits that have already been merged, remove the merge commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants